ftplugin: sh: don't assume MANPAGER makes sense #14679
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benknoble
added a commit
to benknoble/Dotfiles
that referenced
this pull request
May 1, 2024
vim/vim@2f25e40b1 (runtime: configure keywordpg for some file types (#5566), 2023-08-23) added a new keywordprg for Shell files (it was renamed from :Help to ShKeywordPrg in vim/vim@2a281ccca (runtime(sh): Update ftplugin (#13213), 2023-10-07)). Something about it craps out for me, though, dumping terminal garbage all over the screen, and I prefer :Man anyway. See also vim/vim#14679
|
Thanks. Does it make sense to use instead: |
I doubt it: that would mess with the user's environment for that Vim, right? In other words, there's not a good way to scope that to just this command (without the save/unlet/restore block), right? |
|
okay, fine then. @dkearns are you fine with it? |
|
Thank you @benknoble, grepping shows that a similar Ideally, one day one would employ your solution. |
Say you use Vim and set MANPAGER='vim -M +MANPAGER --not-a-term -'; then
:{Zs,S}hKeywordPrg (or K) will crap out and spew terminal garbage into
less when bash's "help" fails. This was introduced by 2f25e40
(runtime: configure keywordpg for some file types (vim#5566), 2023-08-23)
and may be present in other files touched by that commit.
Make the "man" invocation sensible by unsetting MANPAGER in the
environment.
Note that changing MANPAGER for `:terminal` is not needed; Vim within
Vim is perfectly fine.
benknoble
force-pushed
the
fix-ShKeywordPrg-manpager
branch
from
e2e7d93
to
d909ca4
Compare
|
I've fixed this up to change Zsh, too. It's true that my code for Git config and SSH config is a bit more sophisticated, but it does assume you want to use |
|
Thanks, I include it |
chrisbra
added a commit
to chrisbra/vim-zsh
that referenced
this pull request
May 6, 2024
related: vim/vim#14679 Signed-off-by: Christian Brabandt <[email protected]>
zeertzjq
added a commit
to zeertzjq/neovim
that referenced
this pull request
May 7, 2024
runtime(sh,zsh): clear $MANPAGER in ftplugin before shelling out
Say you use Vim and set MANPAGER='vim -M +MANPAGER --not-a-term -'; then
:{Zs,S}hKeywordPrg (or K) will crap out and spew terminal garbage into
less when bash's "help" fails. This was introduced by 2f25e40b1
(runtime: configure keywordpg for some file types (vim/vim#5566), 2023-08-23)
and may be present in other files touched by that commit.
Make the "man" invocation sensible by unsetting MANPAGER in the
environment.
Note that changing MANPAGER for `:terminal` is not needed; Vim within
Vim is perfectly fine.
closes: vim/vim#14679
vim/vim@8d8cb45
Co-authored-by: D. Ben Knoble <[email protected]>
zeertzjq
added a commit
to neovim/neovim
that referenced
this pull request
May 7, 2024
runtime(sh,zsh): clear $MANPAGER in ftplugin before shelling out
Say you use Vim and set MANPAGER='vim -M +MANPAGER --not-a-term -'; then
:{Zs,S}hKeywordPrg (or K) will crap out and spew terminal garbage into
less when bash's "help" fails. This was introduced by 2f25e40b1
(runtime: configure keywordpg for some file types (vim/vim#5566), 2023-08-23)
and may be present in other files touched by that commit.
Make the "man" invocation sensible by unsetting MANPAGER in the
environment.
Note that changing MANPAGER for `:terminal` is not needed; Vim within
Vim is perfectly fine.
closes: vim/vim#14679
vim/vim@8d8cb45
Co-authored-by: D. Ben Knoble <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Say you use Vim and set MANPAGER='vim -M +MANPAGER --not-a-term -'; then :ShKeywordPrg (or K) will crap out and spew terminal garbage into less when bash's "help" fails. This was introduced by 2f25e40 (runtime: configure keywordpg for some file types (#5566), 2023-08-23) and may be present in other files touched by that commit.
Make the "man" invocation sensible by unsetting MANPAGER in the environment.