check_colors: tweak check for t_Co and add missing highlight groups. #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lifepillar
force-pushed
the
fixes-for-check_colors
branch
from
5c21ea7
to
634e85c
Compare
lifepillar
force-pushed
the
fixes-for-check_colors
branch
from
634e85c
to
691f096
Compare
|
I've synced this PR with the current master of this repo. Any chance to have it merged? |
|
thx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Vim 9 script,
&t_Cocannot be directly compared with a number because it has typestring. You must do, e.g.,str2nr(&t_Co) > 256. The parentheses preventcheck_colors.vimto detect the comparison. This PR fixes that.This PR also adds a couple of missing highlight groups.