Relax react requirement to v16.8-18
#56
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This package only uses the following exports from the peer React package: - `useEffect` - `useLayoutEffect` - `useRef` - `useState` (only used in `examples/`, not implementation) These exports are all available in React as of v16.8.0 when hooks were first introduced and they have behaved fairly consistently since then. This seems like sufficient reason to relax the version requirements for the `react` peer dependency. An example use case that benefits from this widened support allows one to upgrade `react` from v16.8.0 to v18.2.0 without having to update this package at the same time, shrinnking the surface area of change that needs to happen all at once.
|
@viktorstrate, and chance of this being approved and merged? Or is there some reason why this is undesirable? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This
react-mathquillpackage only uses the following exports from the peer React package:useEffectuseLayoutEffectuseRefuseState(only used inexamples/, not implementation)These exports are all available in React as of v16.8.0 when hooks were first introduced and they have behaved fairly consistently since then. This seems like sufficient reason to relax the version requirements for the
reactpeer dependency.An example use case that benefits from this widened support allows one to upgrade
reactfrom v16.8.0 to v18.2.0 without having to update this package at the same time, shrinking the surface area of change that needs to happen all at once.