Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: do not suppress poster during audioPosterMode #261

Merged
merged 3 commits into from
May 20, 2024

Conversation

harisha-swaminathan
Copy link
Contributor

Description

Please describe the change as necessary.
If it's a feature or enhancement please be as detailed as possible.
If it's a bug fix, please link the issue that it fixes or describe the bug in as much detail.

Specific Changes proposed

Please list the specific changes involved in this pull request.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Unit Tests updated or fixed
    • Docs/guides updated
  • Reviewed by Two Core Contributors

@harisha-swaminathan harisha-swaminathan changed the base branch from main to 5.x May 9, 2024 23:07
src/play-item.js Outdated Show resolved Hide resolved
Copy link

@Essk Essk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@harisha-swaminathan harisha-swaminathan merged commit de72965 into 5.x May 20, 2024
@roman-bc-dev roman-bc-dev deleted the fix/show-poster-audiopostermode branch May 22, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants