fix: improve types and allow augmentation #8545
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix a few types in
player
andplugin
and allow typescript module augmentation soplugins
can modify the players type as expected.Specific Changes proposed
For type fixes, I used similar patterns found elsewhere in the codebase, just applied following the same pattern. For module augmentation, this pattern should be used:
Ideally one wouldn't need to reach into
dist
but I'm unable to do that without created a named export ofPlayer
onvideo.js
which I didn't think was wanted. Happy to make the change though. JSDoc seems to prevent me from only exporting thetype
of Player without exporting the whole class as well.Requirements Checklist