feat: add an option to render a thumbnail when hovering the progress bar #8542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addition of a frame preview function for the progress bar of the video player on mouseover. The frame displayed corresponds to the frame of the video at the progress bar position where the cursor is.
use Dom utils instead of document to manipulate page content
…thumbnailPreview option to controlbar renames frame tooltip file into thumbnail tooltip file add thumbnailPreview option to controlbar. If set to true, this controlbar option allows to render thumbnail preview when mouseovering the video progressbar
|
💖 Thanks for opening this pull request! 💖 Things that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add "thumbnailPreview" option to the control bar to render a thumbnail when hovering the progress bar
Specific Changes proposed
thumbnailPreview is a boolean. If set to false or not set, the thumbnail won't be rendered below the progress bar. If set to yes, it will be.
Requirements Checklist