chore: migrate NetworkDetails from any -> null|XMLHttpRequest|Response; #3828
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will...
Properly declare the type for
NetworkDetails
Why is this Pull Request needed?
Removes reliance on
any
type in favor of properly declaringNetworkDetails
for better developer ergonomics when matching against HTTP outcomesAre there any points in the code the reviewer needs to double check?
I traced the usage of
NetworkDetails
as best as possible to all existing usages in the codebase and found that in some cases it is declared asnetworkDetails?
type and sometimes is is passed as anull
object. I did not clean this up because technically it could be a breaking change, but converging it so thatnetworkDetails?
is preferred would make sense for code clarity and overall maintainability in the future.Resolves issues:
resolves unnecessary dependence on
any
typeChecklist