Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use docker base image in CI #327

Merged
merged 14 commits into from
Nov 20, 2024
Merged

use docker base image in CI #327

merged 14 commits into from
Nov 20, 2024

Conversation

abe-winter
Copy link
Member

@abe-winter abe-winter commented Nov 18, 2024

What changed

  • consume prebuilt base image in test.yml rather than building every time
  • split test.yml build + test into separate steps

Why

  • intermittent failures of the base image step (example here)
  • clearer output (location of build vs test error is clearer)
  • slightly quicker

Follow-up work

  • scheduled rebuilds of base image

@abe-winter abe-winter marked this pull request as ready for review November 19, 2024 17:56
@abe-winter abe-winter requested a review from a team as a code owner November 19, 2024 17:56
@abe-winter abe-winter requested review from njooma and purplenicole730 and removed request for a team November 19, 2024 17:56
@lia-viam
Copy link
Contributor

for my benefit and posterity can you elaborate/eli5 a bit on consuming the pre-built base image? like where is that image coming from, is it manually uploaded rn or could be scheduled in the future, etc

@abe-winter
Copy link
Member Author

where is that image coming from, is it manually uploaded rn or could be scheduled in the future, etc

the image is created by this job https://github.com/viamrobotics/viam-cpp-sdk/actions/workflows/docker.yml

and it gets uploaded to here https://github.com/viamrobotics/viam-cpp-sdk/pkgs/container/cpp-base/307921886?tag=bullseye-amd64

(if you scroll down on that page, note it embeds the git sha so we have a fairly good idea of where this came from; not sure if the sha is attested by the runner, but they're giving us a blue check on the right side of the page; I think some attestation is happening)

could easily add a cron trigger to docker.yml if we wanted

@abe-winter
Copy link
Member Author

these docker images are also listed on the side of the repo main page if you need to find them in a hurry

image

@abe-winter abe-winter merged commit f49b1f6 into main Nov 20, 2024
6 checks passed
@abe-winter abe-winter deleted the aw-docker-2 branch November 20, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants