-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DATA-3338-fix-stability-of-vision-capture-all-from-camera #4557
Draft
nicksanford
wants to merge
4
commits into
viamrobotics:main
Choose a base branch
from
nicksanford:DATA-3338-fix-stability-of-vision-capture-all-from-camera-2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
DATA-3338-fix-stability-of-vision-capture-all-from-camera #4557
nicksanford
wants to merge
4
commits into
viamrobotics:main
from
nicksanford:DATA-3338-fix-stability-of-vision-capture-all-from-camera-2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
safe to test
This pull request is marked safe to test from a trusted zone
and removed
safe to test
This pull request is marked safe to test from a trusted zone
labels
Nov 15, 2024
nicksanford
force-pushed
the
DATA-3338-fix-stability-of-vision-capture-all-from-camera-2
branch
from
November 18, 2024 18:04
33c6fab
to
501209a
Compare
viambot
added
safe to test
This pull request is marked safe to test from a trusted zone
and removed
safe to test
This pull request is marked safe to test from a trusted zone
labels
Nov 18, 2024
nicksanford
commented
Nov 19, 2024
viambot
added
safe to test
This pull request is marked safe to test from a trusted zone
and removed
safe to test
This pull request is marked safe to test from a trusted zone
labels
Nov 19, 2024
viambot
added
safe to test
This pull request is marked safe to test from a trusted zone
and removed
safe to test
This pull request is marked safe to test from a trusted zone
labels
Nov 20, 2024
nicksanford
force-pushed
the
DATA-3338-fix-stability-of-vision-capture-all-from-camera-2
branch
from
November 21, 2024 19:51
24f1702
to
842ea82
Compare
viambot
added
safe to test
This pull request is marked safe to test from a trusted zone
and removed
safe to test
This pull request is marked safe to test from a trusted zone
labels
Nov 21, 2024
nicksanford
force-pushed
the
DATA-3338-fix-stability-of-vision-capture-all-from-camera-2
branch
from
November 21, 2024 19:54
842ea82
to
583a8e6
Compare
viambot
added
safe to test
This pull request is marked safe to test from a trusted zone
and removed
safe to test
This pull request is marked safe to test from a trusted zone
labels
Nov 21, 2024
viambot
added
safe to test
This pull request is marked safe to test from a trusted zone
and removed
safe to test
This pull request is marked safe to test from a trusted zone
labels
Nov 21, 2024
viambot
added
safe to test
This pull request is marked safe to test from a trusted zone
and removed
safe to test
This pull request is marked safe to test from a trusted zone
labels
Nov 21, 2024
nicksanford
commented
Nov 21, 2024
GetImages = "GetImages" | ||
nextPointCloud = "NextPointCloud" | ||
pointCloudMap = "PointCloudMap" | ||
captureAllFromCamera = "CaptureAllFromCamera" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added captureAllFromCamera
to binary methods
viambot
added
safe to test
This pull request is marked safe to test from a trusted zone
and removed
safe to test
This pull request is marked safe to test from a trusted zone
labels
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(ctx context.Context, _ map[string]*anypb.Any) (interface{}, error)
to(ctx context.Context, _ map[string]*anypb.Any) (data.CaptureResult, error)
see data/collector_types.go for more infodata.NewTabularCaptureResult
to create tabular capture results.