Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCS-1825: Document teleop page as how-to #3675

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

sguequierre
Copy link
Collaborator

  • creates a simple how-to for teleop
  • leaves the question of which widgets up to their machine but explores creating all 4 types of widgets

@viambot viambot added the safe to build This pull request is marked safe to build from a trusted zone label Nov 14, 2024
- A [movement sensor](/components/movement-sensor/)
- A [sensor](/components/sensor/)

See [configure a machine](/how-tos/configure/) for more information.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

figure this covers device requirements and viam app requirements? lmk and I can add more but this isn't a super basic thing to do with viam so I figured a tiny bit of cross-linking was ok

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, I like it

docs/how-tos/configure-teleop-workspace.md Outdated Show resolved Hide resolved
docs/how-tos/configure-teleop-workspace.md Outdated Show resolved Hide resolved
- A [movement sensor](/components/movement-sensor/)
- A [sensor](/components/sensor/)

See [configure a machine](/how-tos/configure/) for more information.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, I like it

docs/how-tos/configure-teleop-workspace.md Outdated Show resolved Hide resolved
docs/how-tos/configure-teleop-workspace.md Outdated Show resolved Hide resolved

- If you have a movement sensor, select a **GPS map**, which allows you to map the location of a machine.
Enter the name of your movement sensor.
Toggle **Historic positions** to on to see how position has changed over time.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you test this? Does this create a heatmap or how is this visualized?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it creates a line I believe from starting position to end. like this:
image

Toggle **Historic positions** to on to see how position has changed over time.

- If you have a sensor, select **Stat** to view a single sensor value.
Enter the name of the sensor for **Sensor name** and enter the key for the value in **Path**, for example `time_unix`.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think for these it would be good to add a tip for people trying to figure out how to get the path (go to machine's test panel and check the returned json object. should probably also include what to do if it's inside another object)

However, this should ideally be a tooltip in the app. Please file the appropriate ticket with a suggestion for copy.

Copy link
Collaborator Author

@sguequierre sguequierre Nov 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are going to make it selectable from a dropdown so I think it's not worth filing that as it would quickly be deprecated, does that make sense? @npentrel

Click **Add widget** and select the appropriate widget for your machine.
Repeat as many times as necessary.

- If you have a camera, select **Camera stream**, which allows you to view a camera stream.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think these should be needed. The UI should be self explanatory from here, shouldn't it? If it isn't this is a place where we should work with Product to improve the UI instead. See notes below

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean to suggest removing all of these bullets? Just want to be sure. I agree the UI should be self explanatory

docs/how-tos/configure-teleop-workspace.md Outdated Show resolved Hide resolved
docs/how-tos/configure-teleop-workspace.md Outdated Show resolved Hide resolved
@viambot
Copy link
Member

viambot commented Nov 18, 2024

You can view a rendered version of the docs from this PR at https://docs-test.viam.dev/3675

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to build This pull request is marked safe to build from a trusted zone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants