Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C link rust #3

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

hisergiorojas
Copy link
Contributor

No description provided.

Copy link
Member

@scott-wilson scott-wilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really really solid work! The only request for this PR is to make the automatically generated files part of the project, and make sure it compiles.

@@ -8,3 +8,6 @@ edition = "2021"

[dependencies]
libc = "0.2"

[build-dependencies]
bindgen = "0.59.2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want to have the generated Rust interface included in the project, so consumers of the library don't have to depend on bindgen + its dependencies.

println!("cargo:rustc-link-search=native={}", copentimeline_lib_path.display());
println!("cargo:rustc-link-lib=static=copentimelineio");

let bindings = bindgen::Builder::default()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Related to the bindgen note.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants