Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Scala support #382

Merged
merged 3 commits into from
Nov 14, 2023
Merged

Add Scala support #382

merged 3 commits into from
Nov 14, 2023

Conversation

oliver-brm
Copy link
Contributor

@oliver-brm oliver-brm commented Nov 14, 2023

Motivation:

Generating a project with the Scala language is currently not supported. This change adds Scala support with Maven and Gradle build systems.

Hint:

Before integrating this change, we need a release of Vert.x Scala support .

Closes #118

@oliver-brm oliver-brm linked an issue Nov 14, 2023 that may be closed by this pull request
@tsegismont tsegismont self-assigned this Nov 14, 2023
@tsegismont tsegismont modified the milestone: 3.1 Nov 14, 2023
@tsegismont tsegismont removed their assignment Nov 14, 2023
@tsegismont
Copy link
Collaborator

Thank you @oliver-brm !

Please ping me when the PR is ready for review

@oliver-brm oliver-brm merged commit c068a5c into vert-x3:master Nov 14, 2023
1 of 2 checks passed
@tsegismont
Copy link
Collaborator

@oliver-brm have you merged this PR incidentally? There are some tests failures. In this case, can you please revert and fix the issues?

@oliver-brm
Copy link
Contributor Author

oliver-brm commented Nov 14, 2023

@tsegismont I'm so sorry! I accidentally pushed to origin instead of my fork... How do we revert this? Seems like I have no permission to revert the PR. I'll check if I can create a reverting PR manually.

@oliver-brm
Copy link
Contributor Author

@tsegismont sorry for the inconvenience again! I created a PR that reverts my mistake. Could you please check? -> #383

@tsegismont
Copy link
Collaborator

@tsegismont I'm so sorry! I accidentally pushed to origin instead of my fork... How do we revert this? Seems like I have no permission to revert the PR. I'll check if I can create a reverting PR manually.

No worries. I thought it was possible to revert PRs (I've seen this button in the past, but I can't find it).

Could you please check? -> #383

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Support generating a Scala project
2 participants