Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supports setting the vfox configuration path via the VFOX_HOME environment variable #82

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Chance-fyi
Copy link
Member

@Chance-fyi Chance-fyi commented Mar 6, 2024

close: #45

internal/path.go Outdated Show resolved Hide resolved
@Chance-fyi Chance-fyi changed the title Supports setting the vfox configuration path via the VFOX_CONFIG environment variable Supports setting the vfox configuration path via the VFOX_HOME environment variable Mar 6, 2024
@aooohan
Copy link
Member

aooohan commented Mar 6, 2024

This also involves the issue of whether there are permissions. In addition, The default permissions granted now are 0755. Since we are allowed to change VFOX_HOME, we should also consider the permissions.

@Chance-fyi
Copy link
Member Author

This also involves the issue of whether there are permissions. In addition, The default permissions granted now are 0755. Since we are allowed to change VFOX_HOME, we should also consider the permissions.

This is a problem, I will add a check for VFOX_HOME permissions.

@Chance-fyi Chance-fyi marked this pull request as draft March 6, 2024 09:52
@Chance-fyi
Copy link
Member Author

Regarding permissions, currently, only errors related to insufficient permissions are being returned.

As for #51, regarding the potential support for multiple users sharing the VFOX_HOME directory, this would require setting permissions to at least 775. We need to discuss this matter further, perhaps it could be addressed in another PR.

@aooohan
Copy link
Member

aooohan commented Mar 7, 2024

Regarding permissions, currently, only errors related to insufficient permissions are being returned.

As for #51, regarding the potential support for multiple users sharing the VFOX_HOME directory, this would require setting permissions to at least 775. We need to discuss this matter further, perhaps it could be addressed in another PR.

Yes, so simply changing VFOX_HOME does not seem to be of much use at present. The default 755 permissions still limit this feature.

@cifaz
Copy link
Contributor

cifaz commented Apr 13, 2024

Can you add command like vfox config store-path=D:/app/vfox
or command vfox config home=D:/app/vfox

@cifaz
Copy link
Contributor

cifaz commented Apr 13, 2024

Can you add command like vfox config store-path=D:/app/vfox

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to change the location of the configuration file
4 participants