Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pattern for a linkseite for social media #710

Merged
merged 7 commits into from
Sep 3, 2024
Merged

pattern for a linkseite for social media #710

merged 7 commits into from
Sep 3, 2024

Conversation

HueHa-v
Copy link
Collaborator

@HueHa-v HueHa-v commented Aug 29, 2024

No description provided.

@HueHa-v HueHa-v linked an issue Aug 29, 2024 that may be closed by this pull request
@HueHa-v HueHa-v requested a review from albig August 29, 2024 12:14
Copy link
Member

@albig albig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bei mir gibt es einen Hinweis auf einen kaputten Block. Wenn ich ihn repariere ändert sich der Block wie folgt:

diff --git a/functions/block-patterns/seiten/linkseite.html b/functions/block-patterns/seiten/linkseite.html
index 38a8e89..ead437d 100644
--- a/functions/block-patterns/seiten/linkseite.html
+++ b/functions/block-patterns/seiten/linkseite.html
@@ -1,7 +1,7 @@
-<!-- wp:cover {"url":"https://sunflower-theme.de/demo/wp-content/uploads/sites/6/2021/03/jan-huber-4OhFZSAT3sw-unsplash_red-1024x620.jpg","id":69,"dimRatio":50,"customOverlayColor":"#928f8a","isDark":false,"layout":{"type":"constrained"}} -->
+<!-- wp:cover {"url":"https://sunflower-theme.de/demo/wp-content/uploads/sites/6/2021/03/jan-huber-4OhFZSAT3sw-unsplash_red-1024x620.jpg","id":69,"alt":"Cover Bild Hintergrund","dimRatio":50,"customOverlayColor":"#928f8a","isUserOverlayColor":true,"isDark":false,"metadata":{"categories":["sunflower-seiten"],"patternName":"sunflower/linkseite","name":"Linkseite"},"layout":{"type":"constrained"}} -->
 <div class="wp-block-cover is-light"><span aria-hidden="true" class="wp-block-cover__background has-background-dim" style="background-color:#928f8a"></span><img class="wp-block-cover__image-background wp-image-69" alt="Cover Bild Hintergrund" src="https://sunflower-theme.de/demo/wp-content/uploads/sites/6/2021/03/jan-huber-4OhFZSAT3sw-unsplash_red-1024x620.jpg" data-object-fit="cover"/><div class="wp-block-cover__inner-container"><!-- wp:group {"layout":{"type":"constrained"}} -->
        <div class="wp-block-group"><!-- wp:image {"id":1608,"sizeSlug":"thumbnail","linkDestination":"none","align":"center"} -->
-       <figure class="wp-block-image aligncenter size-thumbnail"><img src="https://sunflower-theme.de/demo/wp-content/uploads/sites/6/2024/08/prince-akachi-J1OScm_uHUQ-unsplash-1-scaled.jpg" alt="" class="ounded-circle"/></figure>
+       <figure class="wp-block-image aligncenter size-thumbnail"><img src="https://sunflower-theme.de/demo/wp-content/uploads/sites/6/2024/08/prince-akachi-J1OScm_uHUQ-unsplash-1-scaled.jpg" alt="" class="wp-image-1608"/></figure>
        <!-- /wp:image -->
 
        <!-- wp:spacer {"height":"10px"} -->

Ist diese CSS-Classe ounded-circle ein Versehen? Kommt da noch (s)css dazu?

@HueHa-v
Copy link
Collaborator Author

HueHa-v commented Sep 3, 2024

ja, ist ein versehen. sollte rounded-circle aus bootsstrap sein, damit das Bild rund ist.

@albig albig merged commit 45c456b into dev-2.2 Sep 3, 2024
1 check passed
@albig albig deleted the task/fix-638-2 branch September 3, 2024 10:42
albig added a commit that referenced this pull request Sep 3, 2024
* Add WhatsApp sharer button (#651)

* Add WhatsApp sharer button

* Extend GitHub workflow for all dev branches

* Fix coding standard for new sharer

* Avoid using pixabay images in templates and Sunflower instances. (#708)

* Replace background image of block next-events

* Remove sample picture import from sunflower-theme.de

* Update documentation about free image sources

* Fix font im backend editor

* Update templates not to use pixabay images as default

* Fix person and homepage template

* Add optional field for contact-form receiver email (#709)

* Send copy of email in contact-form to sender if desired (#711)

* Fix whole day events (imported and manual edited) (#714)

* Enhance contact form block: show only valid options (#716)

* Add option to show latest posts with 2 or 3 columns (#715)

* pattern for a linkseite for social media (#710)

* add the pattern of linkseite

* Fix block errors

* update linkseite social icons + picture

* add doku to blocks

* add the changes of 2.2 in changelog

* Make linkseite template full-width and with round image

* Fix link to changelog in docu

---------

Co-authored-by: Alexander Bigga <[email protected]>

* Show websitename in page metadata to enhance SEO (search engine optimization) (#718)

---------

Co-authored-by: Hanna H. <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Template für Linkseite integrieren
2 participants