Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attachement reply #13

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Attachement reply #13

wants to merge 2 commits into from

Conversation

grvn-ht
Copy link

@grvn-ht grvn-ht commented Apr 10, 2024

New PR to handle Linked messages & code inside messages

@grvn-ht grvn-ht force-pushed the attachement-reply branch from 3e10de6 to 261e62b Compare April 16, 2024 13:20
@grvn-ht
Copy link
Author

grvn-ht commented Apr 17, 2024 •
edited
Loading

Removed a recursion in attachement type that caused OOM problem.
Also changed way of handling Linked message to handle old message type
Still something not nice in method: getDomainName
I think it's not a good thing to extract it from synapse_url, it will not always be right
Maybe we should directly add Domaine Name variable in .env
what do you think @HerHde ?

@HerHde HerHde requested a review from JonathanTreffler June 17, 2024 15:44
@HerHde HerHde mentioned this pull request Jul 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonathanTreffler JonathanTreffler Awaiting requested review from JonathanTreffler

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@grvn-ht