Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce memory usage in analyser #8061

Merged
merged 6 commits into from May 7, 2024
Merged

reduce memory usage in analyser #8061

merged 6 commits into from May 7, 2024

Conversation

sokra
Copy link
Member

@sokra sokra commented Apr 30, 2024

Description

  • reduce JSValue size by 40 bytes (from 88 bytes)

Testing Instructions

Closes PACK-3029

Copy link

vercel bot commented Apr 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback May 7, 2024 6:23am
examples-gatsby-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback May 7, 2024 6:23am
examples-native-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback May 7, 2024 6:23am
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 7, 2024 6:23am
rust-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 7, 2024 6:23am
5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-designsystem-docs ⬜️ Ignored (Inspect) Visit Preview May 7, 2024 6:23am
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview May 7, 2024 6:23am
examples-svelte-web ⬜️ Ignored (Inspect) Visit Preview May 7, 2024 6:23am
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview May 7, 2024 6:23am
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview May 7, 2024 6:23am

Copy link
Contributor

github-actions bot commented Apr 30, 2024

🟢 Turbopack Benchmark CI successful 🟢

Thanks

Copy link
Contributor

✅ This change can build next-swc

Copy link
Contributor

github-actions bot commented Apr 30, 2024

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)
  • Turbopack Rust benchmark tests (mac/win, non-blocking)

See workflow summary for details

Copy link
Member

@bgw bgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find!

@sokra sokra enabled auto-merge (squash) May 7, 2024 06:05
@sokra sokra merged commit 9de8fd5 into main May 7, 2024
44 of 47 checks passed
@sokra sokra deleted the sokra/analyser-memory branch May 7, 2024 06:11
sokra added a commit to vercel/next.js that referenced this pull request May 8, 2024
* vercel/turbo#8073 <!-- OJ Kwon -
feat(webpack-loaders): support dummy span interface -->
* vercel/turbo#8083 <!-- OJ Kwon - fix(webpack):
print resource, project path when relative calc fails -->
* vercel/turbo#8094 <!-- Tim Neutkens -
Implement bindings for Turbopack trace server -->
* vercel/turbo#8061 <!-- Tobias Koppers - reduce
memory usage in analyser -->
* vercel/turbo#8077 <!-- Alexander Lyon - Remove
async-trait from a few crates -->
* vercel/turbo#8102 <!-- Tobias Koppers - fix
memory counting without custom allocator -->
* vercel/turbo#8096 <!-- Benjamin Woodruff -
turbo-tasks: Expand `<T as TaskOutput>::Return` values in macros -->
* vercel/turbo#8105 <!-- Benjamin Woodruff -
turbopack-node: Use path.join for postcss loader -->
* vercel/turbo#8099 <!-- Tim Neutkens - Replace
websocket with tungstenite for turbo-trace-server -->
* vercel/turbo#8060 <!-- Donny/강동윤 - feat: Add
lint for `grid-template-areas` -->
* vercel/turbo#8110 <!-- Tobias Koppers - fix
lockfile -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants