chore(ci): breakup GH test.yml #8027
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
8 Ignored Deployments
|
🟢 Turbopack Benchmark CI successful 🟢Thanks |
|
✅ This change can build |
|
turbopack and turborepo tests are often blocking each other and there is no good reason to keep them all in one workflow. This PR separates them. Since linting and JS packages are not cleanly separated between the projects, they get their own workflows as well
mehulkar
force-pushed
the
mk/breakup-test
branch
from
85941b8
to
987fe97
Compare
| uses: ./.github/actions/setup-turborepo-environment | ||
| with: | ||
| github-token: "${{ secrets.GITHUB_TOKEN }}" | ||
| node-version: "20" |
There was a problem hiding this comment.
at some point we'll add node 18 to this matrix, JS packages should work on node 18
I think the required check thing is handled by the "Determine Jobs" job in each one. IIUC, any job that is a required check and only runs on some paths needs this handling. All the broken up workflows are duplicating that logic, so there's a final |
| run: | | ||
| cargo groups clippy turborepo-libraries --features rustls-tls -- --deny clippy::all | ||
| - name: Run ast-grep lints |
There was a problem hiding this comment.
Is this accounted for in Turbopack still?
There was a problem hiding this comment.
son confused about what this diff is showing... this is clearly in the branch:
turbo/.github/workflows/turbopack-test.yml
Line 229 in 440dc9d
turbo-orchestrator
bot
added
the
area: docs
turbo-orchestrator
bot
removed
the
area: docs
turbopack and turborepo tests are often blocking each other and
there is no good reason to keep them all in one workflow. This
PR separates them. Since linting and JS packages are not cleanly
separated between the projects, they get their own workflows as well
Closes TURBO-2868