Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(example): add angular getting started example #8002

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

alydemah
Copy link

Description

Testing Instructions

@alydemah alydemah requested review from anthonyshew and a team as code owners April 18, 2024 19:26
@alydemah alydemah requested a review from arlyon April 18, 2024 19:26
@turbo-orchestrator turbo-orchestrator bot added area: examples Improvements or additions to examples owned-by: turborepo labels Apr 18, 2024
Copy link

vercel bot commented Apr 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-designsystem-docs 🔄 Building (Inspect) Visit Preview 💬 Add feedback May 8, 2024 7:20pm
examples-svelte-web 🔄 Building (Inspect) Visit Preview 💬 Add feedback May 8, 2024 7:20pm
5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Visit Preview May 8, 2024 7:20pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Visit Preview May 8, 2024 7:20pm
examples-native-web ⬜️ Ignored (Inspect) Visit Preview May 8, 2024 7:20pm
examples-tailwind-web ⬜️ Ignored (Inspect) Visit Preview May 8, 2024 7:20pm
examples-vite-web ⬜️ Ignored (Inspect) Visit Preview May 8, 2024 7:20pm

Copy link

vercel bot commented Apr 18, 2024

@alydemah is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

@anthonyshew
Copy link
Contributor

Hi, thanks for this contribution!

I haven't gotten a chance to look over this whole PR - but I did notice quickly that the root README.md didn't get updated from the basic template. Could you take a look there and see what updates need to be made?

@turbo-orchestrator turbo-orchestrator bot added the needs: triage New issues get this label. Remove it after triage label May 8, 2024
@alydemah
Copy link
Author

alydemah commented May 8, 2024

Hi,
@anthonyshew Thanks for the quick review, I noticed the missing readme and it should been updated now.

@codexshell
Copy link

codexshell commented May 14, 2024

Hello there folks.

Couldn't help but notice inconsistencies in the example. The most notable one is that the ui package is not any kind of Angular library that am familiar with if such exists. More information on the status of the feature could be helpful.

Alternatively, I can have a complete example ready within the week. This can even include integration with storybook. Am primarily an Angular Developer and am really excited about this feature (mostly because scaffolding a project with nx can take anywhere from 2 mins on a good day, to 20mins on a not so good one).

Am more than willing to take on the challenge and bring the idea to fruition.

@codexshell
Copy link

Just finished working on this feature, wondering whether I should open another pull request.

It's a complete example, similar (but slightly better) to the svelte example. It was actually inspired by it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: examples Improvements or additions to examples needs: triage New issues get this label. Remove it after triage owned-by: turborepo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants