feat(turborepo): new ui + watch mode #7962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @NicholasLYang and the rest of your teammates on |
This was referenced Apr 15, 2024
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
5 Ignored Deployments
|
🟢 Turbopack Benchmark CI successful 🟢Thanks |
🟢 CI successful 🟢Thanks |
NicholasLYang
force-pushed
the
nicholasyang/persistent-tasks
branch
from
0d4f68d
to
02a5e85
Compare
NicholasLYang
force-pushed
the
nicholasyang/watch-with-experimental-ui
branch
from
09b44be
to
c090c69
Compare
NicholasLYang
force-pushed
the
nicholasyang/persistent-tasks
branch
from
02a5e85
to
24a0c13
Compare
NicholasLYang
force-pushed
the
nicholasyang/watch-with-experimental-ui
branch
from
c090c69
to
2050124
Compare
NicholasLYang
force-pushed
the
nicholasyang/persistent-tasks
branch
from
8931497
to
2152b42
Compare
NicholasLYang
force-pushed
the
nicholasyang/watch-with-experimental-ui
branch
from
2050124
to
c69ac3a
Compare
NicholasLYang
force-pushed
the
nicholasyang/persistent-tasks
branch
from
2152b42
to
84b3416
Compare
NicholasLYang
force-pushed
the
nicholasyang/watch-with-experimental-ui
branch
from
c69ac3a
to
e8ceb6f
Compare
NicholasLYang
force-pushed
the
nicholasyang/persistent-tasks
branch
from
84b3416
to
232f44d
Compare
NicholasLYang
force-pushed
the
nicholasyang/watch-with-experimental-ui
branch
from
e8ceb6f
to
53a852f
Compare
NicholasLYang
force-pushed
the
nicholasyang/watch-with-experimental-ui
branch
from
fe028d0
to
78937d6
Compare
NicholasLYang
changed the title
chris-olszewski
requested changes
May 10, 2024
| self.scroll.select(Some(selected_idx + 1)); | ||
| } | ||
| } | ||
| } else { |
There was a problem hiding this comment.
So if a task gets restarted while it's still running it will error?
There was a problem hiding this comment.
That's currently not possible. We purposefully make it so the same task can't be run at the same time, and we haven't implemented cancelation logic. If a change event happens in the middle of a run, we save it and wait for the run to finish before starting up a new execution.
Co-authored-by: Chris Olszewski <[email protected]>
chris-olszewski
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Integrates new UI with watch mode. Pulls out the UI handle and sender outside the
VisitorandRunstruct, so it can be owned by theWatchClient. Also adds anEventfor updating the task names, so on rediscovery we can keep using the same UI thread but just update the task names.Testing Instructions
Give it a shot!
Closes TURBO-2801