update cache handler version and added better logic for opting out of… #65330
+6
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… caching on build
davidsa03
requested review from
ismaelrumzan and
jh3y
and removed request for
a team
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
ijjk
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Update the cache-handler package to the latest and changed logic for opting out of caching during build.
Why?
The current implementation in the cache-handler-redis example requires an environment variable check for
REDIS_AVAILABLEto determine if the server has already started in order to opt out of caching during build. This update leverages theNEXT_PHASEenvironment variable instead.How?
This updates the environment variable check to leverage the
NEXT_PHASEvariable so a user doesn't have to manage a new environment variable.