[turbopack] Use updated RawOutput API #65300
Draft
+31
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijjk
added
created-by: Turbopack team
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
- `polyfill-nomodule.js` is a pre-built file containing polyfills for older browsers (gated by the `<script>` tag `nomodule` attribute). - The turbopack server needs to emit a raw OutputAsset for this file, so that it is copied into the output chunks directory. - That file needs to be passed into `polyfillFiles`, and preserved when we're merging manifests inside of the development server.
Use updated API suggested by sokra in review on #65223: #65223 (comment)
bgw
added a commit
to vercel/turbo
that referenced
this pull request
May 8, 2024
### Description Update `RawOutput` API Updated API suggested by @sokra in review on #65223: vercel/next.js#65223 (comment) Without this change, I don't think this API is useful. This makes the API very similar to `VirtualOutputAsset`. ### Testing Instructions Tested with vercel/next.js#65300 Closes PACK-3034
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use updated API suggested by sokra in review on #65223:
#65223 (comment)
Depends on vercel/turbo#8075 (I'll update this PR with a
Cargo.tomlchange after that ships)