Fix signature field image matching on existing field, in some instances

verbb · Jan 10, 2025 · 81d90a4 · 81d90a4
1 parent ed86a83
commit 81d90a4
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/src/controllers/FieldsController.php b/src/controllers/FieldsController.php
@@ -104,7 +104,9 @@ public function actionGetSignatureImage(): ?Response
 
         // Use UID to prevent easy-guessing of submission to scrape data
         if ($submissionUid && $fieldId) {
-            $submission = Submission::find()->uid($submissionUid)->one();
+            // Don't use a Submission element query, just in case there's a mixup with element/submission UIDs
+            // See https://github.com/verbb/formie/issues/2221
+            $submission = Craft::$app->getElements()->getElementByUid($submissionUid);
 
             if ($submission && $form = $submission->getForm()) {
                 $signatureValue = null;