Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Phonenumber to SyncResult Event #873

Open
wants to merge 727 commits into
base: master
Choose a base branch
from

Conversation

pmuralikrishna111
Copy link

Added Phonenumber to SyncResult Event.

shirioko and others added 30 commits October 13, 2013 01:28
Repaired onProfilePictureChanged event, added onProfilePictureDeleted
Typos fixed as well as incorrectly commented function name
…urrent behavior and it fix the problem if WhatsAPI is being used from other project/path
added full path on the fopen(countries.csv) line,
onGetRequestLastSeen return an array with 4 elements, not with 3!
…urrent behavior and it fix the problem if WhatsAPI is being used from other project/path
onGetRequestLastSeen return an array with 4 elements, not with 3!
added onGetGroupMessage
CodersBrothers and others added 25 commits July 6, 2014 21:08
Now you can send media without downloading the file, just knowing the size and the base64 hash.

TODO: some minor fixes in func.php probably tomorrow
Now broadcast media knowing only size and hash
Send media files knowing only the size and hash - Enhancement venomous0x#826
new ping request from server is like this

```<iq from="s.whatsapp.net" id="1405327577-ping" type="get" xmlns="urn:xmpp:ping"></iq>```
ping response from server changed 
Fix from venomous0x#700
Update event to let the user get filehash
Added Simple CLI and fixes to exampleFunctional
If number add to group
profile picture update notification node now without message node
update profile picture update notification
@pmuralikrishna111
Copy link
Author

May I know which one should be enhanced..

$callbackEvent = function(WhatsAppEventListener $listener) use ($result) {
$listener->onGetSyncResult($result);
$callbackEvent = function(WhatsAppEventListener $listener) use ($phone,$result) {
$listener->onGetSyncResult($phone,$result);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes the Public API of the onGetSyncResult event. It would be better to add the phone number to the SyncResult class instead.

@hubail hubail force-pushed the master branch 2 times, most recently from d56e5ea to e6cf5a5 Compare May 3, 2015 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.