Skip to content

Commit

Permalink
add a define _topdir for rpmbuild
Browse files Browse the repository at this point in the history
  • Loading branch information
@SergeiShtepa
SergeiShtepa committed Feb 8, 2024
1 parent 1bb715a commit 52db3dd
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions pkg/rpm/blksnap-kmp-suse/build.sh
View file
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,12 @@ PACKAGE_NAME="blksnap"
PACKAGE_VERSION="$1"
PACKAGE_VENDOR="Veeam Software Group GmbH"
#PACKAGE_VENDOR="$2"
if [ -z ${PACKAGE_VERSION} ]
if [ -z "${PACKAGE_VERSION}" ]
then
echo >&2 "Version parameters is not set."
exit
fi
if [ -z ${PACKAGE_VENDOR} ]
if [ -z "${PACKAGE_VENDOR}" ]
then
echo >&2 "Vendor parameters is not set."
exit
Expand Down Expand Up @@ -73,5 +73,5 @@ echo "SPECS:"
ls ${BUILD_DIR}/SPECS

cd ${BUILD_DIR}
rpmbuild --ba SPECS/${PACKAGE_NAME}.spec
rpmbuild --define "_topdir ${BUILD_DIR}" --ba SPECS/${PACKAGE_NAME}.spec
cd ${PROJECT_DIR}

6 comments on commit 52db3dd

@Fantu
Copy link
Contributor

@Fantu Fantu commented on 52db3dd Mar 7, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SergeiShtepa hi, why you did new branch VAL-6.1.2 instead update VAL-6.1? I don't think there are any substantial compatibility changes that require it.
There are still also various link pointing to VAL-6.1, for user that want simply do a build with newer kernel support

@SergeiShtepa
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi.
This is done in order to align with the release numbers of Veeam Agent for Linux.
It is possible fixes in version 6.1. That's why the branch is being maintained.
Please do not ask me why the revision number is changed for the new version of the product.

@Fantu
Copy link
Contributor

@Fantu Fantu commented on 52db3dd Mar 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SergeiShtepa I don't understand, near all software do branches for major versions (some also for minor) but don't make sense to do also for "bugfix" (and other minor things).
I saw a commit "Merge branch 'VAL-6.1' into VAL-6.2", is not that branch name 6.1.2 is a mistake and should be VAL-6.2 instead?

@SergeiShtepa
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi.
Perhaps this is slightly different from the common ways of doing development, but.
The bottom line is that the branch names exactly match the version of the product they are being created for.
I don't determine what the version number of the next release will be. I can only make a clear match so that there is no confusion.

And Veeam has adopted best practices for making bug fixes and building updates.
For example, only the most necessary critical fixes can get into the VAL-6.1 branch.
I am not making changes to this branch without the approval of the QA team.
The 6.1.2 branch has been moved to the code-freeze state. I suppose there will be no more changes in it.

And I don't sync all branches with the public repository.
For example, I have a 6.2 branch, but I do not know if the product will be released with this version.

@Fantu
Copy link
Contributor

@Fantu Fantu commented on 52db3dd Mar 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SergeiShtepa the VAL-6.1.2 branch continues to seem strange to me, however if it remains like this it should be added to the list of those in the note at the beginning of the readme on master. Or probably replacing VAL-6.1 (in the list I mean).
Both cases could also cause a bit of confusion among users

If you need only kernel module updated with latest kernel versions support and latest fixes for it build kernel module from VAL-6.0, VAL-6.1 or VAL-6.1.2 branches based on your Veeam agent for linux version

If you need only kernel module updated with latest kernel versions support and latest fixes for it build kernel module from VAL-6.0 or VAL-6.1.2 branches based on your Veeam agent for linux version

but at least if mentioned there perhaps they won't open issues regarding the 6.8 kernel (supported in the new branch)

about readme in the branch under compatibility notes also update this line

blksnap kernel module support kernel versions from 5.10 up to 6.8

and I think can be useful mention that need a kernel built with one or more specific config: as saw in #83 but I don't know if only CONFIG_FUNCTION_TRACER, or others are needed

@SergeiShtepa
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you're right.
I'll think about it.
Today I will choose more appropriate words for the readme.

Please sign in to comment.