Fix AS504x DIAG and MAGN addresses. #462
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just checking, was this tested? If so using what setup? |
|
I currently have no way to test this as I didn't add miso to any of my as5047 test boards. It would be good if someone who has been using the as504x with miso can give some feedback on this. |
|
Should this be included the the v6.0 firmware release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to AS5047D datasheet (https://ams.com/documents/20143/36005/AS5047D_DS000394_2-00.pdf), DIAAGC is 0x3FFC and MAG is 0x3FFD, in enc_as504x.c they are, however, incremented by one, reading back MAG for DIAG and ANGLEUNC for MAG.