Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): add link to macOS ARM builds #22144

Merged
merged 4 commits into from
Jan 15, 2025
Merged

chore(ci): add link to macOS ARM builds #22144

merged 4 commits into from
Jan 15, 2025

Conversation

pront
Copy link
Member

@pront pront commented Jan 8, 2025 •
edited
Loading

Summary

Add a download link for macOS ARM builds. To avoid 404s, only render this new link if the version is >= v0.44.0.

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

How did you test this PR?

https://pront-macos-arm-website-link.d1a7j77663uxsc.amplifyapp.com/download/

ARM download box shows up for 0.44.0 and nightly and it doesn't show up for older versions.

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the "no-changelog" label to this PR.

Checklist

  • Please read our Vector contributor resources.
  • If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
    run dd-rust-license-tool write to regenerate the license inventory and commit the changes (if any). More details here.

References

closes: #10193

@github-actions github-actions bot added the domain: external docs Anything related to Vector's external, public documentation label Jan 8, 2025
@pront pront added no-changelog Changes in this PR do not need user-facing explanations in the release changelog and removed domain: external docs Anything related to Vector's external, public documentation labels Jan 8, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2025

Your preview site for the VRL Playground will be ready in a few minutes, please allow time for it to build.

Heres your preview link:
VRL Playground preview

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2025

Your preview site for the vector.dev will be ready in a few minutes, please allow time for it to build.

Heres your preview link:
vector.dev preview

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2025

Your preview site for the Rust Doc will be ready in a few minutes, please allow time for it to build.

Heres your preview link:
Rust Doc preview

@datadog-vectordotdev
Copy link

datadog-vectordotdev bot commented Jan 8, 2025 •
edited
Loading

Datadog Report

Branch report: pront/macos-arm-website-link
Commit report: de5549f
Test service: vector

✅ 0 Failed, 7 Passed, 0 Skipped, 25.42s Total Time

@github-actions github-actions bot added the domain: external docs Anything related to Vector's external, public documentation label Jan 8, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2025

Your preview site for the vector.dev will be ready in a few minutes, please allow time for it to build.

Heres your preview link:
vector.dev preview

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2025

Your preview site for the VRL Playground will be ready in a few minutes, please allow time for it to build.

Heres your preview link:
VRL Playground preview

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2025

Your preview site for the Rust Doc will be ready in a few minutes, please allow time for it to build.

Heres your preview link:
Rust Doc preview

@pront pront added this to the Vector v0.44.0 milestone Jan 13, 2025
@github-actions GitHub Actions
Copy link

Your preview site for the vector.dev will be ready in a few minutes, please allow time for it to build.

Heres your preview link:
vector.dev preview

@github-actions GitHub Actions
Copy link

Your preview site for the Rust Doc will be ready in a few minutes, please allow time for it to build.

Heres your preview link:
Rust Doc preview

@github-actions GitHub Actions
Copy link

Your preview site for the VRL Playground will be ready in a few minutes, please allow time for it to build.

Heres your preview link:
VRL Playground preview

@pront pront marked this pull request as ready for review January 15, 2025 15:43
@pront pront requested review from a team as code owners January 15, 2025 15:43
@github-actions GitHub Actions
Copy link

Your preview site for the vector.dev will be ready in a few minutes, please allow time for it to build.

Heres your preview link:
vector.dev preview

@github-actions GitHub Actions
Copy link

Your preview site for the Rust Doc will be ready in a few minutes, please allow time for it to build.

Heres your preview link:
Rust Doc preview

@github-actions GitHub Actions
Copy link

Your preview site for the VRL Playground will be ready in a few minutes, please allow time for it to build.

Heres your preview link:
VRL Playground preview

@pront pront requested review from bfung and jszwedko January 15, 2025 16:03
@pront pront enabled auto-merge January 15, 2025 16:04
@pront pront added this pull request to the merge queue Jan 15, 2025
Merged via the queue into master with commit b92e285 Jan 15, 2025
61 checks passed
@pront pront deleted the pront/macos-arm-website-link branch January 15, 2025 18:51
pront added a commit that referenced this pull request Jan 15, 2025
@pront
chore(ci): add link to macOS ARM builds (#22144)
2a5c98a 
* chore(ci): add link to macOS ARM builds

* tweak
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@urseberry urseberry urseberry approved these changes

@bfung bfung Awaiting requested review from bfung

@jszwedko jszwedko Awaiting requested review from jszwedko

Assignees
No one assigned
Labels
domain: external docs Anything related to Vector's external, public documentation no-changelog Changes in this PR do not need user-facing explanations in the release changelog
Projects
None yet
Milestone
Vector v0.44.0
Development

Successfully merging this pull request may close these issues.

Add release builds for aarch64-apple-darwin
2 participants
@pront @urseberry