-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(vrl): add docs for new timezone
option in parse_timestamp function
#22121
base: master
Are you sure you want to change the base?
Conversation
|
||
{ | ||
name: "timezone" | ||
description: "The [TZ database](\(urls.tz_time_zones)) format." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's describe a bit more here when this option is useful. You wrote some good context in the issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tried to add more details to the timezone
argument
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, let's wait for a review from the docs team.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I just offered a quick suggested edit for the description. 🚀
Co-authored-by: Brett Blue <[email protected]>
Head branch was pushed to by a user without write access
I have intentionally updated the example without day saving time. |
Summary
This is drafted documents for vectordotdev/vrl#1207
Change Type
Is this a breaking change?
How did you test this PR?
Does this PR include user facing changes?
Checklist
Cargo.lock
), pleaserun
dd-rust-license-tool write
to regenerate the license inventory and commit the changes (if any). More details here.References