hide popups when a table is destroyed

vdm-io · May 26, 2022 · dd2974c · dd2974c
1 parent 32c3843
commit dd2974c
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 1 deletion.
diff --git a/dist/js/tabulator_esm.js b/dist/js/tabulator_esm.js
@@ -194,6 +194,8 @@ class Popup extends CoreFeature{
 
         this.blurEvent = this.hide.bind(this, false);
         this.escEvent = this._escapeCheck.bind(this);
+
+        this.destroyBinding = this.hide.bind(this, true);
     }
 
     _lookupContainer(){
@@ -311,6 +313,8 @@ class Popup extends CoreFeature{
         this._fitToScreen(x, y, parentEl, parentOffset, position);
 
         this.visible = true;
+
+        this.subscribe("table-destroy", this.destroyBinding);
 
         return this;
     }
@@ -406,6 +410,8 @@ class Popup extends CoreFeature{
             if(this.blurCallback && !silent){
                 this.blurCallback();
             }
+
+            this.unsubscribe("table-destroy", this.destroyBinding);
         }
 
         return this;

diff --git a/dist/js/tabulator_esm.js.map b/dist/js/tabulator_esm.js.map
diff --git a/src/js/core/tools/Popup.js b/src/js/core/tools/Popup.js
@@ -22,6 +22,8 @@ export default class Popup extends CoreFeature{
 
         this.blurEvent = this.hide.bind(this, false);
         this.escEvent = this._escapeCheck.bind(this);
+
+        this.destroyBinding = this.hide.bind(this, true);
     }
 
     _lookupContainer(){
@@ -139,6 +141,8 @@ export default class Popup extends CoreFeature{
         this._fitToScreen(x, y, parentEl, parentOffset, position);
 
         this.visible = true;
+
+        this.subscribe("table-destroy", this.destroyBinding);
 
         return this;
     }
@@ -234,6 +238,8 @@ export default class Popup extends CoreFeature{
             if(this.blurCallback && !silent){
                 this.blurCallback();
             }
+
+            this.unsubscribe("table-destroy", this.destroyBinding);
         }
 
         return this;