fix issue with row manager display row array management

vdm-io · Aug 21, 2022 · 32c9718 · 32c9718
1 parent 5d5ab85
commit 32c9718
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 29 deletions.
diff --git a/dist/js/tabulator_esm.js b/dist/js/tabulator_esm.js
@@ -22702,7 +22702,7 @@ class RowManager extends CoreFeature{
 			case "displayPipeline":
 				for(let i = index; i < this.displayPipeline.length; i++){
 					let result = this.displayPipeline[i].handler((i ? this.getDisplayRows(i - 1) : this.activeRows).slice(0), renderInPosition);
-					
+
 					this.setDisplayRows(result || this.getDisplayRows(i - 1).slice(0), i);
 				}
 
@@ -22745,22 +22745,11 @@ class RowManager extends CoreFeature{
 
 	//set display row pipeline data
 	setDisplayRows(displayRows, index){
-
-		var output = true;
-
-		if(index && typeof this.displayRows[index] != "undefined"){
-			this.displayRows[index] = displayRows;
-			output = true;
-		}else {
-			this.displayRows.push(displayRows);
-			output = index = this.displayRows.length -1;
-		}
-
+		this.displayRows[index] = displayRows;
+
 		if(index == this.displayRows.length -1){
 			this.displayRowsCount = this.displayRows[this.displayRows.length -1].length;
 		}
-
-		return output;
 	}
 
 	getDisplayRows(index){

diff --git a/dist/js/tabulator_esm.js.map b/dist/js/tabulator_esm.js.map
diff --git a/src/js/core/RowManager.js b/src/js/core/RowManager.js
@@ -712,7 +712,7 @@ export default class RowManager extends CoreFeature{
 			case "displayPipeline":
 				for(let i = index; i < this.displayPipeline.length; i++){
 					let result = this.displayPipeline[i].handler((i ? this.getDisplayRows(i - 1) : this.activeRows).slice(0), renderInPosition);
-					
+
 					this.setDisplayRows(result || this.getDisplayRows(i - 1).slice(0), i);
 				}
 
@@ -755,22 +755,11 @@ export default class RowManager extends CoreFeature{
 
 	//set display row pipeline data
 	setDisplayRows(displayRows, index){
-
-		var output = true;
-
-		if(index && typeof this.displayRows[index] != "undefined"){
-			this.displayRows[index] = displayRows;
-			output = true;
-		}else{
-			this.displayRows.push(displayRows);
-			output = index = this.displayRows.length -1;
-		}
-
+		this.displayRows[index] = displayRows;
+
 		if(index == this.displayRows.length -1){
 			this.displayRowsCount = this.displayRows[this.displayRows.length -1].length;
 		}
-
-		return output;
 	}
 
 	getDisplayRows(index){