Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gRPC error msg handling for lb-gateway handler #2663

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

:recycle: refactor: replace ParseError with FromError

59a39bc
Select commit
Loading
Failed to load commit list.
Open

Fix gRPC error msg handling for lb-gateway handler #2663

:recycle: refactor: replace ParseError with FromError
59a39bc
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 3, 2024 in 1s

24.06% (+0.07%) compared to da0ac80

View this Pull Request on Codecov

24.06% (+0.07%) compared to da0ac80

Details

Codecov Report

Attention: Patch coverage is 0% with 196 lines in your changes missing coverage. Please review.

Project coverage is 24.06%. Comparing base (da0ac80) to head (59a39bc).

Files with missing lines Patch % Lines
pkg/gateway/lb/handler/grpc/handler.go 0.00% 174 Missing ⚠️
pkg/gateway/lb/handler/grpc/aggregation.go 0.00% 22 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2663      +/-   ##
==========================================
+ Coverage   23.99%   24.06%   +0.07%     
==========================================
  Files         539      539              
  Lines       47179    47070     -109     
==========================================
+ Hits        11319    11329      +10     
+ Misses      35090    34972     -118     
+ Partials      770      769       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.