Skip to content
This repository has been archived by the owner on Oct 22, 2024. It is now read-only.

Introduced two version support feature #101

Merged
merged 10 commits into from
May 13, 2024
Merged

Introduced two version support feature #101

merged 10 commits into from
May 13, 2024

Conversation

hlts2
Copy link
Collaborator

@hlts2 hlts2 commented May 8, 2024

Now that Vald can support multiple versions, clients should also be able to support multiple versions.
In this PR, I implemented a workflow to support multiple versions.
The main logic is implemented as a common workflow in vald-client-ci, so I implemented a call to it.

Summary by CodeRabbit

Summary by CodeRabbit

  • New Features

    • Updated release workflow to include licensing information, trigger configurations, and specific client settings.
    • Introduced a new workflow for syncing Vald using GitHub Actions with enhanced security measures and specific configurations.
  • Chores

    • Updated .gitignore to exclude specific directories and files.
    • Enhanced the Makefile with new variables and targets to improve build and deployment processes.

Copy link

coderabbitai bot commented May 8, 2024

Walkthrough

Walkthrough

The recent updates aim to enhance automation for testing, releasing, and syncing tasks through improved GitHub workflows. Changes to .gitignore and Makefile boost project setup and development processes with new variables and targets for efficiency and consistency.

Changes

File Path Summary of Changes
.github/workflows/release.yaml
.github/workflows/sync.yaml
Updated release.yaml for release workflow and added sync.yaml for Vald syncing with authentication secrets and workflow setup.
.gitignore Added /vald and lein to the ignore list.
Makefile Enhanced with new variables, modified assignments, and additional targets for repository management and testing.
VALD_SHA Introduces a single-line change related to the VALD_SHA value.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@hlts2 hlts2 marked this pull request as draft May 8, 2024 11:14
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 1b83f8d and e277bac.
Files selected for processing (5)
  • .github/workflows/e2e.yaml (1 hunks)
  • .github/workflows/release.yaml (1 hunks)
  • .github/workflows/sync.yaml (1 hunks)
  • .gitignore (1 hunks)
  • Makefile (3 hunks)
Files skipped from review due to trivial changes (2)
  • .github/workflows/e2e.yaml
  • .gitignore
Additional comments not posted (4)
.github/workflows/release.yaml (1)

20-24: Ensure tag patterns align with versioning strategy.

Makefile (3)

62-62: Ensure the downloaded script is from a trusted source and consider verifying its integrity.


94-94: Verify the repository URL and ensure it is correct and accessible.

Verification successful

The repository URL used in the Makefile for cloning the Vald repository has been successfully verified as correct and accessible. The cloning process completed without critical errors, confirming the repository's availability.

Scripts Executed

The following scripts were executed for the analysis:


Script:

#!/bin/bash
# Description: Verify the accessibility of the Vald repository URL.

# Test: Attempt to clone the repository. Expect: The repository should be successfully cloned.
git clone https://github.com/vdaas/vald

Length of output: 126


125-125: Ensure the updated SHA value is correctly propagated to dependent systems or configurations.

.github/workflows/release.yaml Outdated Show resolved Hide resolved
.github/workflows/sync.yaml Outdated Show resolved Hide resolved
.github/workflows/sync.yaml Outdated Show resolved Hide resolved
.github/workflows/release.yaml Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
hlts2 added 3 commits May 9, 2024 14:26
Signed-off-by: Hiroto Funakoshi <[email protected]>
Signed-off-by: hlts2 <[email protected]>
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between e277bac and 4ea8c9b.
Files selected for processing (3)
  • .github/workflows/release.yaml (1 hunks)
  • Makefile (3 hunks)
  • VALD_SHA (1 hunks)
Files skipped from review due to trivial changes (2)
  • .github/workflows/release.yaml
  • VALD_SHA
Files skipped from review as they are similar to previous changes (1)
  • Makefile

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 4ea8c9b and 0a933e5.
Files selected for processing (1)
  • .github/workflows/sync.yaml (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • .github/workflows/sync.yaml

@hlts2 hlts2 marked this pull request as ready for review May 9, 2024 14:29
@hlts2
Copy link
Collaborator Author

hlts2 commented May 9, 2024

@coderabbitai review

Copy link

coderabbitai bot commented May 9, 2024

Actions Performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@hlts2 hlts2 requested a review from kmrmt May 10, 2024 03:14
.github/workflows/sync.yaml Outdated Show resolved Hide resolved
Signed-off-by: Hiroto Funakoshi <[email protected]>
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 0a933e5 and 71156f0.
Files selected for processing (3)
  • .github/workflows/e2e.yaml (1 hunks)
  • .github/workflows/release.yaml (1 hunks)
  • .github/workflows/sync.yaml (1 hunks)
Files skipped from review as they are similar to previous changes (3)
  • .github/workflows/e2e.yaml
  • .github/workflows/release.yaml
  • .github/workflows/sync.yaml

@hlts2 hlts2 merged commit 8cd0d44 into main May 13, 2024
4 checks passed
@hlts2 hlts2 deleted the feat/two-version-support branch May 13, 2024 03:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants