-
Notifications
You must be signed in to change notification settings - Fork 2
Introduced two version support feature #101
Conversation
Signed-off-by: hlts2 <[email protected]>
WalkthroughWalkthroughThe recent updates aim to enhance automation for testing, releasing, and syncing tasks through improved GitHub workflows. Changes to Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 3
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (5)
- .github/workflows/e2e.yaml (1 hunks)
- .github/workflows/release.yaml (1 hunks)
- .github/workflows/sync.yaml (1 hunks)
- .gitignore (1 hunks)
- Makefile (3 hunks)
Files skipped from review due to trivial changes (2)
- .github/workflows/e2e.yaml
- .gitignore
Additional comments not posted (4)
.github/workflows/release.yaml (1)
20-24
: Ensure tag patterns align with versioning strategy.Makefile (3)
62-62
: Ensure the downloaded script is from a trusted source and consider verifying its integrity.
94-94
: Verify the repository URL and ensure it is correct and accessible.Verification successful
The repository URL used in the Makefile for cloning the Vald repository has been successfully verified as correct and accessible. The cloning process completed without critical errors, confirming the repository's availability.
Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the accessibility of the Vald repository URL. # Test: Attempt to clone the repository. Expect: The repository should be successfully cloned. git clone https://github.com/vdaas/valdLength of output: 126
125-125
: Ensure the updated SHA value is correctly propagated to dependent systems or configurations.
Signed-off-by: Hiroto Funakoshi <[email protected]>
Signed-off-by: Hiroto Funakoshi <[email protected]>
Signed-off-by: hlts2 <[email protected]>
Signed-off-by: hlts2 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- .github/workflows/release.yaml (1 hunks)
- Makefile (3 hunks)
- VALD_SHA (1 hunks)
Files skipped from review due to trivial changes (2)
- .github/workflows/release.yaml
- VALD_SHA
Files skipped from review as they are similar to previous changes (1)
- Makefile
Signed-off-by: hlts2 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- .github/workflows/sync.yaml (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- .github/workflows/sync.yaml
Signed-off-by: hlts2 <[email protected]>
@coderabbitai review |
Actions PerformedReview triggered.
|
Signed-off-by: hlts2 <[email protected]>
This reverts commit 73cc64e.
Signed-off-by: Hiroto Funakoshi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- .github/workflows/e2e.yaml (1 hunks)
- .github/workflows/release.yaml (1 hunks)
- .github/workflows/sync.yaml (1 hunks)
Files skipped from review as they are similar to previous changes (3)
- .github/workflows/e2e.yaml
- .github/workflows/release.yaml
- .github/workflows/sync.yaml
Now that Vald can support multiple versions, clients should also be able to support multiple versions.
In this PR, I implemented a workflow to support multiple versions.
The main logic is implemented as a common workflow in vald-client-ci, so I implemented a call to it.
Summary by CodeRabbit
Summary by CodeRabbit
New Features
Chores
.gitignore
to exclude specific directories and files.