Skip to content

Commit

Permalink
Add setup language (#272)
Browse files Browse the repository at this point in the history
* feat: add setup language action

Signed-off-by: hlts2 <[email protected]>

* fix: deleted unnecessary action definision

Signed-off-by: hlts2 <[email protected]>

* fix: refactor

Signed-off-by: hlts2 <[email protected]>

* fix: deleted unnecessary steps

Signed-off-by: hlts2 <[email protected]>

---------

Signed-off-by: hlts2 <[email protected]>
  • Loading branch information
hlts2 authored Apr 23, 2024
1 parent 35a6aca commit 2c70b86
Show file tree
Hide file tree
Showing 4 changed files with 47 additions and 21 deletions.
18 changes: 3 additions & 15 deletions .github/actions/e2e/action.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,16 +27,9 @@ inputs:
runs:
using: "composite"
steps:
- uses: actions/checkout@v3
- name: Setup Go environment
if: ${{ inputs.client_type == 'go' }}
uses: ./.github/actions/setup-go
- name: Setup Node environment
if: ${{ inputs.client_type == 'node' }}
uses: ./.github/actions/setup-node
- name: Setup Node environment
if: ${{ inputs.client_type == 'java' }}
uses: ./.github/actions/setup-java
- uses: ./.github/actions/setup-language
with:
client_type: ${{ inputs.client_type }}
- uses: rinx/[email protected]
with:
version: latest
Expand Down Expand Up @@ -88,11 +81,6 @@ runs:
make ci/test # NOTE: we may change to 'ci/test/start'
kill $pid
# NOTE: debug step
- name: Debug git changes
shell: bash
run: |
git diff
- name: Delete downloaded dataset
shell: bash
run: |
Expand Down
39 changes: 39 additions & 0 deletions .github/actions/setup-language/action.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
#
# Copyright (C) 2019-2024 vdaas.org vald team <[email protected]>
#
# Licensed under the Apache License, Version 2.0 (the "License");
# You may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# https://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#
name: "Setup language environment"
description: "A action to set up language environment"
inputs:
version:
description: "The version to use."
required: false
default: ""
client_type:
description: "Set client type. e.g) go, python, node, java"
required: true
runs:
using: "composite"
steps:
- name: Setup Go environment
if: ${{ inputs.client_type == 'go' }}
uses: ./.github/actions/setup-go
- name: Setup Node environment
if: ${{ inputs.client_type == 'node' }}
uses: ./.github/actions/setup-node
with:
node_version: '18'
- name: Setup Node environment
if: ${{ inputs.client_type == 'java' }}
uses: ./.github/actions/setup-java
5 changes: 2 additions & 3 deletions .github/workflows/_release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -78,10 +78,9 @@ jobs:
fetch-depth: 1
- name: Install Protoc
uses: arduino/setup-protoc@v1
- name: Setup Node environment
uses: ./.github/actions/setup-node
- uses: ./.github/actions/setup-language
with:
node-version: '18'
client_type: ${{ inputs.client_type }}
# - name: Publish
# run: |
# make ci/package/publish
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/_sync.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,6 @@ jobs:
VALD_CHECKOUT_REF: ${{ inputs.vald_checkout_src_ref }}
- name: Build proto
run: |
# make ci/all
echo "Install dependencies"
make ci/deps/install
Expand All @@ -75,7 +73,9 @@ jobs:
image_tag: ${{ env.IMAGE_TAG }}
- name: Push
run: |
git push
git push origin ${REF}
env:
REF: ${{ inputs.client_checkout_target_ref }}
- name: Create tag
if: ${{ inputs.enable_tag_push == true }}
continue-on-error: true
Expand Down

0 comments on commit 2c70b86

Please sign in to comment.