Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(pmp-api): minimize api image #231

Merged
merged 1 commit into from
May 6, 2020
Merged

Conversation

MaciejSikorski
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Locally I noticed that the API image has the size of 1GB

Issue Number: N/A

What is the new behavior?

Locally the API image has the size of 350MB

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Can be still improved by removing angular dependencies, but it can't be easily achieved because of valueadd-poland/valueadd#54
Additionally, we can choose a different way to achieve a smaller bundle size. We need to check the result of this question

@Sikora00 Sikora00 merged commit 270020e into master May 6, 2020
@Sikora00 Sikora00 deleted the feature/minimize-api-image branch May 6, 2020 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants