Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(earn): implement withdraw saga #5433

Merged
merged 1 commit into from
May 20, 2024
Merged

Conversation

satish-ravi
Copy link
Contributor

Description

Submits the withdraw and claim tx. Uses swap and transfer as types for the pending tx, which will be updated in a followup

Test plan

Unit tests, manual

Successful withdraw tx: https://arbiscan.io/tx/0x1a478de2f1c87c47af5e1a86c8eef82b34c2f8563c9a4cdd1cc5c4022c3c436c
Successful reward tx: https://arbiscan.io/tx/0x57294a12d68d58378b6e4fa07209dfa2ccfa94dd0d60279fbcb8a9ef6e123883

Related issues

Backwards compatibility

Yes

Network scalability

If a new NetworkId and/or Network are added in the future, the changes in this PR will:

  • Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)

Copy link

codecov bot commented May 18, 2024

Codecov Report

Attention: Patch coverage is 94.73684% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 86.30%. Comparing base (da2b95c) to head (c80f3b6).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5433   +/-   ##
=======================================
  Coverage   86.29%   86.30%           
=======================================
  Files         754      754           
  Lines       30853    30908   +55     
  Branches     5275     5280    +5     
=======================================
+ Hits        26624    26674   +50     
- Misses       4002     4007    +5     
  Partials      227      227           
Files Coverage Δ
src/analytics/Events.tsx 100.00% <100.00%> (ø)
src/analytics/Properties.tsx 100.00% <ø> (ø)
src/earn/EarnCollectScreen.tsx 97.50% <ø> (ø)
src/earn/saga.ts 93.93% <94.33%> (+0.11%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da2b95c...c80f3b6. Read the comment docs.

@satish-ravi satish-ravi added this pull request to the merge queue May 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 20, 2024
@MuckT MuckT added this pull request to the merge queue May 20, 2024
Merged via the queue into main with commit a7efc6d May 20, 2024
16 checks passed
@MuckT MuckT deleted the satish/act-1180-submit-withdraw-tx branch May 20, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants