Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(earn): earn transaction details content #5425

Merged
merged 24 commits into from
May 20, 2024
Merged

feat(earn): earn transaction details content #5425

merged 24 commits into from
May 20, 2024

Conversation

MuckT
Copy link
Collaborator

@MuckT MuckT commented May 17, 2024

Description

Adds transaction details content for EarnDeposit, EarnClaimReward and EarnWithdraw.

Screenshots

iOS Deposit iOS Claim iOS Withdraw

Test plan

  • Tested locally on iOS
  • Tested locally on Android
  • Unit tests updated

Related issues

Backwards compatibility

Yes

Network scalability

If a new NetworkId and/or Network are added in the future, the changes in this PR will:

  • Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)

Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.34%. Comparing base (64fd9eb) to head (e36c352).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5425      +/-   ##
==========================================
+ Coverage   86.27%   86.34%   +0.07%     
==========================================
  Files         754      755       +1     
  Lines       30785    30893     +108     
  Branches     5257     5278      +21     
==========================================
+ Hits        26559    26675     +116     
+ Misses       3999     3991       -8     
  Partials      227      227              
Files Coverage Δ
src/transactions/feed/TransactionDetailsScreen.tsx 92.23% <100.00%> (+11.62%) ⬆️
...rc/transactions/feed/detailContent/EarnContent.tsx 100.00% <100.00%> (ø)
test/values.ts 100.00% <100.00%> (ø)

... and 10 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64fd9eb...e36c352. Read the comment docs.

Base automatically changed from tomm/act-1182 to main May 17, 2024 21:40
# Conflicts:
#	locales/base/translation.json
#	src/transactions/feed/EarnFeedItem.test.tsx
#	src/transactions/feed/TransactionDetailsScreen.tsx
@MuckT MuckT added this pull request to the merge queue May 20, 2024
Merged via the queue into main with commit c55cd0a May 20, 2024
16 checks passed
@MuckT MuckT deleted the tomm/act-1182-1 branch May 20, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants