Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(buttons): Change onboarding buttons to new design #5423

Merged
merged 2 commits into from
May 20, 2024

Conversation

finnian0826
Copy link
Contributor

@finnian0826 finnian0826 commented May 16, 2024

Description

Update the onboarding buttons

Test plan

unit/e2e tests pass

Manual Tests:
Simulator Screenshot - iPhone 14 Pro - 2024-05-16 at 12 33 56
Simulator Screenshot - iPhone 14 Pro - 2024-05-16 at 12 34 02
Simulator Screenshot - iPhone 14 Pro - 2024-05-16 at 12 34 25

Related issues

  • N/A

Backwards compatibility

Yes

Network scalability

If a new NetworkId and/or Network are added in the future, the changes in this PR will:

  • Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)

Copy link

codecov bot commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.27%. Comparing base (a76f334) to head (fa245a2).
Report is 9 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5423      +/-   ##
==========================================
+ Coverage   86.23%   86.27%   +0.03%     
==========================================
  Files         750      754       +4     
  Lines       30557    30847     +290     
  Branches     5216     5273      +57     
==========================================
+ Hits        26351    26612     +261     
- Misses       3978     4008      +30     
+ Partials      228      227       -1     
Files Coverage Δ
src/components/Button.tsx 93.82% <100.00%> (-6.18%) ⬇️
src/import/ImportWallet.tsx 83.62% <ø> (ø)
src/keylessBackup/KeylessBackupProgress.tsx 99.20% <ø> (ø)
src/onboarding/registration/EnableBiometry.tsx 100.00% <ø> (ø)
...boarding/registration/OnboardingRecoveryPhrase.tsx 86.53% <ø> (ø)
src/onboarding/registration/RegulatoryTerms.tsx 96.82% <ø> (ø)
src/onboarding/welcome/Welcome.tsx 97.01% <ø> (ø)
src/verify/VerificationStartScreen.tsx 91.73% <ø> (ø)

... and 22 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a76f334...fa245a2. Read the comment docs.

@finnian0826 finnian0826 marked this pull request as ready for review May 16, 2024 18:21
@finnian0826
Copy link
Contributor Author

finnian0826 commented May 16, 2024

The paste button on restore wallet looks a bit weird, should that one stay as the old version? It feels weird to keep around the style for just one use case, but I'm not seeing any other way to override color to white.

@satish-ravi
Copy link
Contributor

satish-ravi commented May 17, 2024

The paste button on restore wallet looks a bit weird, should that one stay as the old version? It feels weird to keep around the style for just one use case, but I'm not seeing any other way to override color to white.

Looks like this sets a rounded: false property, but the gray with border type doesn't seem to honor it and always sets a borderRadius. I'd suggest we fix this if its simple, or leave onboarding_secondary as deprecated and use it in one place, with a follow up ticket

@finnian0826
Copy link
Contributor Author

Kept onboarding secondary as it was used for the paste button and looks weird in a different style, added a follow-up ticket for removing the deprecated style: https://linear.app/valora/issue/ACT-1200/placeholder-remove-deprecated-onboarding-button-style

Copy link
Collaborator

@MuckT MuckT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching the undesired change with the paste button!

@finnian0826 finnian0826 added this pull request to the merge queue May 20, 2024
Merged via the queue into main with commit 6c3366d May 20, 2024
17 checks passed
@finnian0826 finnian0826 deleted the finnian0826/onboarding-buttons-to-black branch May 20, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants