Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] add MSI format installation package for Windows system #120

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lonewayren
Copy link

@lonewayren lonewayren commented Aug 25, 2023

for #1

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@lonewayren lonewayren force-pushed the feature/add-msi branch 2 times, most recently from 95949f4 to 28eea28 Compare August 25, 2023 07:30
@lonewayren lonewayren mentioned this pull request Aug 25, 2023
@utkuozdemir
Copy link
Owner

Closes #1 .

@utkuozdemir
Copy link
Owner

Thank you very much for the work, looks promising!
I have to go through it and test it, maybe change few things here and there. Unfortunately I don't know when I'll find some time. But I'll really try to do it.

@lonewayren
Copy link
Author

You're welcome! I'm glad to hear that you find the work promising. It's completely understandable that finding time can be challenging. hope this work will be done soon, best regards!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants