Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve tradebook inconsistencies #126

Merged
merged 6 commits into from
Mar 5, 2024
Merged

Resolve tradebook inconsistencies #126

merged 6 commits into from
Mar 5, 2024

Conversation

stephanieyflu
Copy link
Contributor

No description provided.

@stephanieyflu stephanieyflu self-assigned this Nov 18, 2023
@stephanieyflu stephanieyflu marked this pull request as draft November 25, 2023 20:43
@stephanieyflu stephanieyflu marked this pull request as ready for review November 30, 2023 20:50
@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Nov 30, 2023
abeerfatima
abeerfatima approved these changes Mar 5, 2024
View reviewed changes
Copy link
Contributor

@abeerfatima abeerfatima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks Stephanie!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 5, 2024
@abeerfatima abeerfatima merged commit fba416b into main Mar 5, 2024
1 check passed
@abeerfatima abeerfatima deleted the resolve-inconsistencies branch March 5, 2024 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abeerfatima abeerfatima abeerfatima approved these changes

Assignees

@stephanieyflu stephanieyflu

Labels
lgtm This PR has been approved by a maintainer size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stephanieyflu @abeerfatima