Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
Description
Currently, s2e-core has two responsibilities: first: library as the core functionality of S2E; second: sample implementation of S2E user.
However, these are both located in the same directory (root), so it is very difficult to tell where the sample implementation begins. This is a significant barrier for beginners.
Also, when we want to create a new S2E user, the current sample implementation cannot be copied in its entirety and used like a template.
In this PR, create a new directory,
example/
, and isolate the sample implementation into it.Test results
build & run
Impact
No API changes.
Although, the procedure to run example (directory for example) is different.
Therefore, the documentation need to be update.
Supplementary information
For the original purpose, we would also like to move
settings
, which are data used at runtime.But, since organizing ExtLibraries would require more changes, this PR is only for the source code.