USWDS-Site - Changelog: Form group error style improvements [#5999] #2773
Conversation
There was a problem hiding this comment.
@mahoneycm, LGTM, only have one tiny change, a question and a request.
Change: Line 9: Margins are now uniform across various screen sizes and no longer shifts content. should be Margins are now uniform across various screen sizes and no longer shift content. (shift is singular since Margins is plural.)
Question: You have the versionUswds. Should that be N.N.N?
Request: How do you get this diff into these requests for changes?
:)
|
Walked through change requests and how to commit them together with @cathybaptista the above issues! Ready for your re-review @cathybaptista ! |
There was a problem hiding this comment.
question: Wondering if we should add a changelog for each affected form component here. Thinking since it is a visual change, we should make it easy for users to know when it changed.
There was a problem hiding this comment.
Looking through old changelogs it looks like we've done a bit of both when updating larger sweeping form styles (updating each changelog vs. updating only the form changelog). It'll probably be a good idea since certain components like file input and character count will dynamically implement this state, at least for those components.
Moving forward, should we establish consistency / a pattern for when to update each component vs. leaving it at the form page level?
|
@amyleadem can you take another look? |
Summary
Changelog for uswds/uswds#5999
Related PR
uswds/uswds#5999
Preview link
Form component changelog →