-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Public Sans - POAM: December '24 #330
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mahoneycm, I am not sure if this experience is something we want to message out. Let me know and if it's not something we need to tackle because its just on my local, then I approve.
- on public-sans, verified that gemfiles and package.json are updated according to table.
- ran
npm start
:warning: 224 repetitive deprecation warnings omitted.
- ran
npm run serve
: up and running npm run test:a11y
(while localhost is being served from the serve script) this was failing, I had to run:npx browser-driver-manager install chrome
. Then it succeeded:
npx axe http://localhost:4000/, http://localhost:4000/public-sans-100/ --tags wcag2a
Running axe-core 4.10.2 in chrome-headless
Testing http://localhost:4000/ ... please wait, this may take a minute.
0 violations found!
Testing http://localhost:4000/public-sans-100/ ... please wait, this may take a minute.
0 violations found!
Testing complete of 2 pages
@cathybaptista thanks for pointing that out! I added a note in the testing instructions 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! :)
Summary
POAM updates for November + December 2024
Related issue
uswds/uswds-team#413
Resolves https://github.com/uswds/public-sans/security/dependabot/85
Preview link
Public Sans →
Major changes
3.10.0
Dependency updates
found 0 vulnerabilities
Here's the updated table:
Gem updates
Testing and review
Gulp commands run without error
npm run start
npm run serve
npm run test:a11y
(while localhost is being served from the serve script)