Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing whitespace in create memo relation dialog #2950

Closed
wants to merge 5 commits into from

Conversation

TheMaksym
Copy link

@TheMaksym
Copy link
Author

Not exactly sure what error occurred on the front end test. This is in fact my first open source contribution so this is for sure a learning process.

@MehadND
Copy link
Contributor

MehadND commented Feb 12, 2024

Not exactly sure what error occurred on the front end test. This is in fact my first open source contribution so this is for sure a learning process.

Hi @TheMaksym, the frontend test failed because you need to have new line at the very end of file after export default.

Steps to resolve this

  1. cd web
  2. run npm run lint --fix

or

manually enter a new line after export default ...

Then push the changes.

A general advice that I would give to you would be to run npm run lint and npm run lint --fix before you push any changes. This way any linter errors are easy to catch and fixable.

@@ -106,7 +116,7 @@ const CreateMemoRelationDialog: React.FC<Props> = (props: Props) => {
inputValue={searchText}
value={selectedMemos}
multiple
onInputChange={(_, value) => setSearchText(value.trim())}
onInputChange={(_, value) => setSearchText(value)}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can only remove .trim() that will fulfill your needs. The other changes don't seem too important.

@boojack boojack closed this May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants