Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add variables auto completion #2190

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

MasterLambaster
Copy link

Description

Add autocomplete for environment variables.

Screen.Recording.2024-04-27.at.19.58.21.mov

The trigger is {{ that shows all available environment variables. Supports all fields that have collection passed to it, i.e auth, headers etc.
Might need sanity check for all the places where it's currently applied.
Fixes #1141, #606, #412.

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.

Publishing to New Package Managers

Please see here for more information.

@busy-panda
Copy link

I am having a little bug:

image

You can reproduce with the collection under /bruno/packages/bruno-tests/collection
with environment prod

The suggested value "process" shouldn't be here.

Also I don't think, you should display the value of the variable.
It will display secrets on the screen, which is not good in terms of security.

@MasterLambaster
Copy link
Author

@busy-panda process is an nested object that could be accessed, normally via dot notation. It's only visible if it's actually set.
Regarding hiding values: there are couple existing issues for the hiding secret values and it should be done on the global level rather this particular case.

@acuenca-facephi
Copy link

Nice job, this should be included in the following releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autocompletion of headers value
3 participants