Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed save all function failing with JSON in body | issue: (#2130) #2157

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DmytroCrawford
Copy link

Description

fix for: #2130

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

TLDR:

The "saveMultipleRequests" would fail during a save with JSON in the body. There was a reassignment to a read-only object. I fixed this by making the field mutable and reassigning the body if the type is JSON.

Steps to reproduce/test:

  1. Create new collection
  2. Create 2 new requests
  3. Name them something
  4. Add a JSON body to them
  5. Click to close and click Save all

Prefix:

output
On an save all exit with JSON in body, save will fail.

Postfix:

output1
Now postfix, the save all function works perfectly without issue.

Publishing to New Package Managers

Please see here for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant