Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/wsse auth #2136

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

dwolter-emarsys
Copy link

Description

Contribution Checklist:

  • [ x] The pull request only addresses one issue or adds one feature.
  • [x ] The pull request does not introduce any breaking changes
  • [ x] I have added screenshots or gifs to help explain the change if applicable.
  • [x ] Screenshot 2024-04-19 at 11 29 31 AM
  • [ x] I have read the contribution guidelines.
  • [ x] Create an issue and link to the pull request.

Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.

Publishing to New Package Managers

Please see here for more information.

@helloanoop
Copy link
Contributor

@dwolter-emarsys This is fantastic 🔥

Would love to get this merged.
Just one thing.

Can we use the term password instead of secret ?
I haven't used WSSE, Base don my limited search on looking at various code examples and other client UI's, I see password being used instead of the term secret

@dwolter-emarsys
Copy link
Author

Hello @helloanoop !

Thanks for the note! I confirmed with some colleagues that 'password' is the generally used term, even though we use 'secret' internally.

I just updated all the references to use 'password' instead and confirmed that it looks correct in Electron.

Let me know if any other updates need to be made!

Cheers,
Dylan

@dwolter-emarsys
Copy link
Author

Hi @helloanoop ,

Just checking back in- is there anything else you'd like changed before merging?

Thanks!
Dylan

@helloanoop helloanoop self-assigned this May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants