-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggest adding no_main
for error[E0601]
#1113
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
cmichi
reviewed
May 16, 2023
Co-authored-by: Michael Müller <[email protected]>
As discussed via dm, let's omit the tail end of the error output and exit like this:
(with the last part in red) |
cmichi
approved these changes
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #1076,
no_main
is now required. This PR adds a suggestion in case of the errorerror[E0601]:
main` function not found in crate...This is the result:
Note that the suggestion must appear before the compiler error because we can't know for sure how many lines the error message will encompass, so we just print it first.
Introduces duct which allows for easily building command expressions and working with capturing the
stdout
andstderr
.Maintaing the progress bar
An earlier iteration was using
BufReader::lines
to read the capturedstderr
and check for the error code for the missing main function. However this came with the downside of the familiar progress bar (see below) not being displayed.I have been able to get that to work again with some hacking. The result involves reading the reader one byte at a time and redirecting that straight to
stderr
, while maintaining a small buffer to check for the known error. I am aware that this is not the most efficient way, but it was the only way to get the progress bar displaying as it does when not capturingstderr
.