DX-1019: Read Your Writes #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdogan
reviewed
Jul 22, 2024
|
I have fixed the problems in the tests, added asyncio support. Only the pipeline tests are not passing because the fix for them are not deployed to instance we are running the test on. If you want, I can disable these tests and merge this PR as it is |
|
Cloud team stated that all replicas are updated to the most recent version. I guess this shouldn't be happening? |
|
Oh, I assumed that since pipeline tests were failing 1.10.11 might not be deployed yet, but it was. I think we also need to change some logic in pipeline implementation to make it work. Let me send a fix for it |
mdumandag
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.