Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Local and Deployment Project Tests #123

Merged
merged 17 commits into from
Oct 11, 2024
Merged

CI: Local and Deployment Project Tests #123

merged 17 commits into from
Oct 11, 2024

Conversation

fahreddinozcan
Copy link
Contributor

@fahreddinozcan fahreddinozcan commented Oct 6, 2024

This PR introduces a test pipeline, which also builds & deploys projects to various platforms and test on production. The Platform tests introduced with this PR:

  • Cloudflare
    • Deployment
    • Local
  • Next.js
    • Deployment
    • Local

Copy link

linear bot commented Oct 6, 2024

Copy link

vercel bot commented Oct 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ratelimit-with-vercel-kv ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 11, 2024 7:47am

@fahreddinozcan
Copy link
Contributor Author

The pipeline actually works now as you can see in this action. However, this might still break sometimes, but that's due to ratelimit tests being flaky.

@fahreddinozcan fahreddinozcan self-assigned this Oct 6, 2024
@ytkimirti
Copy link
Contributor

Is fixing the flaky tests something trivial @fahreddinozcan?

Comment on lines 226 to 227
UPSTASH_REDIS_REST_URL: ${{ secrets.UPSTASH_REDIS_REST_URL }}
UPSTASH_REDIS_REST_TOKEN: ${{ secrets.UPSTASH_REDIS_REST_TOKEN }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm nitpicking here but we don't need these since they are given in the top level anyways. It should work without these lines

@fahreddinozcan
Copy link
Contributor Author

Is fixing the flaky tests something trivial @fahreddinozcan?

not really sure. maybe we should open a new ticket for that. wdyt @CahidArda

@@ -0,0 +1 @@
console.log("Hello via Bun!");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@CahidArda
Copy link
Contributor

Is fixing the flaky tests something trivial @fahreddinozcan?

not really sure. maybe we should open a new ticket for that. wdyt @CahidArda

yes, it's not that trivial. we can open another task.

run: echo "//registry.npmjs.org/:_authToken=${{secrets.NPM_TOKEN}}" > .npmrc

- name: Publish release candidate
run: npm publish --access public --tag=canary
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ci

Comment on lines 20 to 21
"module": "index.ts",
"type": "module"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need these?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bun init command probably adds them automatically. removed

@@ -0,0 +1 @@
console.log("Hello via Bun!");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably not, removed it

@fahreddinozcan
Copy link
Contributor Author

Final state actually works, see here

@fahreddinozcan fahreddinozcan merged commit 235762b into main Oct 11, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants