-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Local and Deployment Project Tests #123
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
The pipeline actually works now as you can see in this action. However, this might still break sometimes, but that's due to ratelimit tests being flaky. |
Is fixing the flaky tests something trivial @fahreddinozcan? |
.github/workflows/tests.yaml
Outdated
UPSTASH_REDIS_REST_URL: ${{ secrets.UPSTASH_REDIS_REST_URL }} | ||
UPSTASH_REDIS_REST_TOKEN: ${{ secrets.UPSTASH_REDIS_REST_TOKEN }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm nitpicking here but we don't need these since they are given in the top level anyways. It should work without these lines
not really sure. maybe we should open a new ticket for that. wdyt @CahidArda |
examples/nextjs/index.ts
Outdated
@@ -0,0 +1 @@ | |||
console.log("Hello via Bun!"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👀
yes, it's not that trivial. we can open another task. |
.github/workflows/tests.yaml
Outdated
run: echo "//registry.npmjs.org/:_authToken=${{secrets.NPM_TOKEN}}" > .npmrc | ||
|
||
- name: Publish release candidate | ||
run: npm publish --access public --tag=canary |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ci
"module": "index.ts", | ||
"type": "module" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we need these?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bun init
command probably adds them automatically. removed
examples/cloudflare-workers/index.ts
Outdated
@@ -0,0 +1 @@ | |||
console.log("Hello via Bun!"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably not, removed it
Final state actually works, see here |
This PR introduces a test pipeline, which also builds & deploys projects to various platforms and test on production. The Platform tests introduced with this PR: