-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update symbiote to v2 #714
base: main
Are you sure you want to change the base?
Conversation
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
@@ -1,5 +1,5 @@ | |||
import { FormInput } from '../../index.js'; | |||
|
|||
() => <uc-form-input ctx-name="my-uploader" />; | |||
() => <uc-form-input ctx="my-uploader" />; |
Check warning
Code scanning / CodeQL
Expression has no effect Warning test
@@ -4,28 +4,28 @@ | |||
import { OutputFileEntry, FuncCollectionValidator, FuncFileValidator } from '../index.js'; | |||
|
|||
// @ts-expect-error untyped props | |||
() => <uc-config ctx-name="1" something="wrong"></uc-config>; | |||
() => <uc-config ctx="1" something="wrong"></uc-config>; |
Check warning
Code scanning / CodeQL
Expression has no effect Warning test
// allow common html attributes and required ctx-name | ||
() => <uc-config ctx-name="1" id="1" class="1" hidden></uc-config>; | ||
// allow common html attributes and required ctx | ||
() => <uc-config ctx="1" id="1" class="1" hidden></uc-config>; |
Check warning
Code scanning / CodeQL
Expression has no effect Warning test
|
||
// allow key prop | ||
() => <uc-config ctx-name="1" key={1}></uc-config>; | ||
() => <uc-config ctx="1" key={1}></uc-config>; |
Check warning
Code scanning / CodeQL
Expression has no effect Warning test
}; | ||
|
||
// accept config attributes | ||
() => <uc-config ctx-name="1" multiple multipleMax={1} multipleMin={2} accept="str" />; | ||
() => <uc-config ctx="1" multiple multipleMax={1} multipleMin={2} accept="str" />; |
Check warning
Code scanning / CodeQL
Expression has no effect Warning test
() => <uc-cloud-image-editor ctx-name="my-editor" css-src="url" uuid="123124" />; | ||
() => <uc-cloud-image-editor ctx-name="my-editor" css-src="url" uuid="123124" tabs="tab" crop-preset="preset" />; | ||
() => <uc-cloud-image-editor ctx-name="my-editor" css-src="url" cdn-url="url" />; | ||
() => <uc-cloud-image-editor ctx="my-editor" css-src="url" uuid="123124" />; |
Check warning
Code scanning / CodeQL
Expression has no effect Warning test
() => <uc-cloud-image-editor ctx-name="my-editor" css-src="url" uuid="123124" tabs="tab" crop-preset="preset" />; | ||
() => <uc-cloud-image-editor ctx-name="my-editor" css-src="url" cdn-url="url" />; | ||
() => <uc-cloud-image-editor ctx="my-editor" css-src="url" uuid="123124" />; | ||
() => <uc-cloud-image-editor ctx="my-editor" css-src="url" uuid="123124" tabs="tab" crop-preset="preset" />; |
Check warning
Code scanning / CodeQL
Expression has no effect Warning test
() => <uc-cloud-image-editor ctx-name="my-editor" css-src="url" cdn-url="url" />; | ||
() => <uc-cloud-image-editor ctx="my-editor" css-src="url" uuid="123124" />; | ||
() => <uc-cloud-image-editor ctx="my-editor" css-src="url" uuid="123124" tabs="tab" crop-preset="preset" />; | ||
() => <uc-cloud-image-editor ctx="my-editor" css-src="url" cdn-url="url" />; |
Check warning
Code scanning / CodeQL
Expression has no effect Warning test
// @ts-expect-error - no css-url | ||
() => <uc-cloud-image-editor ctx-name="my-uploader" />; | ||
// @ts-expect-error - no cdn-src or uuid | ||
() => <uc-cloud-image-editor ctx="my-uploader" />; |
Check warning
Code scanning / CodeQL
Expression has no effect Warning test
@@ -0,0 +1,5 @@ | |||
() => <uc-config ctx="my-uploader" />; |
Check warning
Code scanning / CodeQL
Expression has no effect Warning test
@@ -0,0 +1,5 @@ | |||
() => <uc-config ctx="my-uploader" />; | |||
() => <uc-config ctx-name="my-uploader" />; |
Check warning
Code scanning / CodeQL
Expression has no effect Warning test
() => <uc-config ctx-name="my-uploader" />; | ||
|
||
// @ts-expect-error - should fall when both ctx and ctx-name are provided | ||
() => <uc-config ctx-name="my-uploader" ctx="another-ctx" />; |
Check warning
Code scanning / CodeQL
Expression has no effect Warning test
# Conflicts: # solutions/file-uploader/inline/FileUploaderInline.js
No description provided.