Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't wait to send GH updates on error/done #2

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

icio
Copy link
Contributor

@icio icio commented Jan 17, 2023

There's a risk that the process will be killed while waiting.

Paul Scott added 3 commits January 17, 2023 10:20
There's a risk that the process will be killed while waiting.
@icio
Copy link
Contributor Author

icio commented Jan 17, 2023

Haven't set up CI yet, so:

$ git log -1 --oneline
7e7a5ec (HEAD -> no-debounce-done, origin/no-debounce-done) Don't wait to send GH updates on error/done.

$ git status
On branch no-debounce-done
Your branch is up to date with 'origin/no-debounce-done'.

nothing to commit, working tree clean

$ go version
go version go1.19.5 linux/amd64


$ go test
PASS
ok      github.com/unravelin/gcb2gh     11.014s

@icio
Copy link
Contributor Author

icio commented Jan 17, 2023

It looks like there's a further issue where we conclude the last-known build step is done but leave the commit status as pending:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant